This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix issue with duplicated played to end observer in MediaElement #11360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
commented
Jul 8, 2020
| @@ -24,9 +24,7 @@ public sealed class MediaElementRenderer : ViewRenderer<MediaElement, UIView> | |||
| [Internals.Preserve(Conditional = true)] | |||
| public MediaElementRenderer() | |||
| { | |||
| Xamarin.Forms.MediaElement.VerifyMediaElementFlagEnabled(nameof(MediaElementRenderer)); | |||
|
|
|||
| _playedToEndObserver = NSNotificationCenter.DefaultCenter.AddObserver(AVPlayerItem.DidPlayToEndTimeNotification, PlayedToEnd); | |||
There was a problem hiding this comment.
We already add the observer here
StephaneDelcroix
approved these changes
Jul 8, 2020
|
I'd retarget this to 4.8 |
|
@jsuarezruiz Can you please rebase this on 4.8.0 to get rid of the extra commits? Thanks! |
|
@samhouts Retarget to 4.8.0 :) |
samhouts
approved these changes
Jul 16, 2020
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix issue with duplicated played to end observer in
MediaElementon iOS.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Core Gallery and navigate to the MediaElement Gallery. Reproduce the video and move the time to the end. MediaEnded must be invoked only one time.
PR Checklist