This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix datetimepickerlocalization #11474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
memu8
force-pushed
the
fix-datetimepickerlocalization
branch
from
4d69328
to
72dc33d
Compare
memu8
force-pushed
the
fix-datetimepickerlocalization
branch
from
72dc33d
to
f8ca115
Compare
hartez
suggested changes
Jul 20, 2020
| @@ -0,0 +1,9 @@ | |||
| using System.Globalization; | |||
There was a problem hiding this comment.
Can we change the file name to match the interface name?
| @@ -71,7 +71,7 @@ | |||
| </Target> | |||
|
|
|||
| <Target Name="_StrongName" AfterTargets="Build" DependsOnTargets="_SetSnExe" Condition="'$(TargetPath)' != ''" Inputs="$(TargetPath)" Outputs="$(IntermediateOutputPath)Sn.stamp"> | |||
| <Exec Command='"$(SnExe)" -R $(TargetPath) ..\xamarin.forms.snk' Condition=" '$(SignAssembly)' == 'true' " /> | |||
| <Exec Command=""$(SnExe)" -R $(TargetPath) ..\xamarin.forms.snk" Condition=" '$(SignAssembly)' == 'true' " /> | |||
There was a problem hiding this comment.
These changes can probably be reverted.
| @@ -5,7 +5,7 @@ | |||
| <PropertyGroup> | |||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | |||
| <iOSPlatform Condition=" '$(iOSPlatform)' == '' ">iPhone</iOSPlatform> | |||
| <Platform Condition=" '$(Platform)' == '' ">$(iOSPlatform)</Platform> | |||
| <Platform Condition=" '$(Platform)' == '' ">iPhoneSimulator</Platform> | |||
There was a problem hiding this comment.
Was this change intentional?
| // DatePicker Format String: d, M, y | ||
| // Separator: "/" | ||
| [Test] | ||
| public void DatePickerOneDigit() |
There was a problem hiding this comment.
It looks like several of these tests follow the same general format - would it be possible to use the TestCase attribute and create fewer test methods?
samhouts
reviewed
Jul 24, 2020
| @@ -160,7 +162,31 @@ void UpdateDateFromModel(bool animate) | |||
| if (_picker.Date.ToDateTime().Date != Element.Date.Date) | |||
| _picker.SetDate(Element.Date.ToNSDate(), animate); | |||
|
|
|||
| Control.Text = Element.Date.ToString(Element.Format); | |||
| //can't use Element.Format because it won't display the correct format if the region and language are set differently | |||
| if (Element.Format.Equals("") || Element.Format.Equals("d") || Element.Format.Equals("D")) | |||
There was a problem hiding this comment.
Do you think we should use something like string.IsNullOrWhitespace instead of .Equals("")?
|
I think the issue #11520 still exists after this PR. On UWP I tried using "HH:mm" but it does not use a leading 0 in the picker or in the display of the selected value:
I think the format the UWP picker is displaying is "H:mm". |
memu8
force-pushed
the
fix-datetimepickerlocalization
branch
from
1c7bf16
to
ca5c809
Compare
PureWeen
added
the
blocker
PureWeen
force-pushed
the
fix-datetimepickerlocalization
branch
from
597c872
to
e10cca9
Compare
rmarinho
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The Format property of the DatePicker and TimePicker creates consistent changes of the date and time displays. Also, the DatePicker format is consistent with the iOS default for specific region and language settings.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
The DatePicker and TimePicker displays and pickers might change depending on the format property as well as the regional settings.
Before/After Screenshots
Before:
After:
Testing Procedure
Create DatePicker and TimePickers on Android, iOS, and UWP and play around with different format properties as well as different regional settings to see if the date and time picker displays and picker stay consistent and follow the region's culture default format for date and time respectively
PR Checklist