Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Core] More Shapes constructors #11490

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[Core] More Shapes constructors #11490

merged 1 commit into from
Jul 28, 2020

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jul 20, 2020

Description of Change

Added missing shapes constructors with parameters. Useful creating Shapes using C#.

API Changes

Added Shapes Segments and Transformations constructors

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Must pass the added unit tests. Can create shapes transformations and segments using a constructor with parameters.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using spaces instead of tabs? :P

public SkewTransform()
{

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's likely some indentation issue here

@samhouts samhouts merged commit 8f7aa4a into 4.8.0 Jul 28, 2020
@samhouts samhouts deleted the shapes-ctors branch July 28, 2020 21:14
@samhouts samhouts added this to the 4.8.0 milestone Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants