Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix FlyoutIsPresented when set from Navigating #11565

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Fix FlyoutIsPresented when set from Navigating #11565

merged 4 commits into from
Jul 28, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • If the FlyoutIsPresented toggles while animation is active just cancel the animation
  • Set AutomationIds for flyout menu
  • Fix issue when setting FlyoutIsPresented to true during load

Issues Resolved

Platforms Affected

  • iOS
  • Android

Testing Procedure

  • ui test included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen removed the request for review from StephaneDelcroix July 26, 2020 22:52
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jul 26, 2020
@PureWeen PureWeen added this to the 4.7.0 milestone Jul 26, 2020
@PureWeen
Copy link
Contributor Author

UI tests are green

API 19 failure was from timeout everything else passed

@samhouts samhouts merged commit c941bd1 into 4.7.0 Jul 28, 2020
@samhouts samhouts deleted the fix_11247 branch July 28, 2020 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts approved these changes

@rmarinho rmarinho Awaiting requested review from rmarinho

Assignees

@rmarinho rmarinho

@samhouts samhouts

Labels
4.7.0 regression on 4.7.0 a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. Core i/regression p/Android p/iOS 🍎 t/bug 🐛
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWeen @samhouts @rmarinho