This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix the memory leak problem of ListViewRenderer _headerRenderer #11699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
rmarinho
approved these changes
Aug 12, 2020
samhouts
added
the
approved
riverar
approved these changes
Aug 13, 2020
rmarinho
pushed a commit
that referenced
this pull request
Aug 31, 2020
rmarinho
pushed a commit
that referenced
this pull request
Sep 2, 2020
pictos
pushed a commit
to pictos/Xamarin.Forms
that referenced
this pull request
Sep 12, 2020
domagojmedo
pushed a commit
to domagojmedo/Xamarin.Forms
that referenced
this pull request
Sep 12, 2020
pictos
pushed a commit
to pictos/Xamarin.Forms
that referenced
this pull request
Sep 12, 2020
jsuarezruiz
pushed a commit
that referenced
this pull request
Sep 17, 2020
shyunMin
pushed a commit
to shyunMin/Xamarin.Forms
that referenced
this pull request
Feb 19, 2021
Axemasta
pushed a commit
to Axemasta/Xamarin.Forms
that referenced
this pull request
Apr 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When we changed the Element with empty HeaderElement, the ListViewRenderer will enter UpdateHeader method to update the
_headerRendererfield. But theUpdateHeadermethod will only call the_headerRenderer.Dispose()and do not release the reference.This means that the old "_headerRenderer" object will be referenced by "ListViewRenderer" resulting in a memory leak
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist