Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Shell FlyoutWidth and FlyoutHeight #12161

Merged
merged 10 commits into from
Dec 11, 2020
Merged

Shell FlyoutWidth and FlyoutHeight #12161

merged 10 commits into from
Dec 11, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Sep 17, 2020 •
edited
Loading

Description of Change

Allow users to specify the Width and Height of the flyout on shell. This let's you expand the flyout to git across the entire screen or raise the flyout up for DualScreen cases or if you want it to be just above the TabBar

API Changes

Added:

  • double Shell.FlyoutWidth { get; set; } //Bindable Property
  • double Shell.FlyoutHeight {get; set;} //Bindable Property

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Behavioral/Visual Changes

UWP

Default

image

Modified WxH

image

Android

Default

image

Modified WxH

image

iOS

Default

image

Modified WxH
image

Testing Procedure

  • Shell store has a demo of these properties that you can play with

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Sep 17, 2020
pictos
pictos approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested here and it's working well. (I didn't run on iOS)

Xamarin.Forms.Platform.Android/Renderers/ShellFlyoutRenderer.cs Outdated Show resolved Hide resolved
@PureWeen PureWeen changed the base branch from 5.0.0 to main October 29, 2020 18:31
@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Nov 13, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Nov 13, 2020
@PureWeen PureWeen changed the base branch from main to 5.0.0 November 13, 2020 21:34
@rmarinho rmarinho modified the milestones: 5.0.0, 5.0.1 Nov 16, 2020
@PureWeen PureWeen removed the request for review from StephaneDelcroix December 1, 2020 06:27
@PureWeen
Copy link
Contributor Author

PureWeen commented Dec 3, 2020

https://dev.azure.com/xamarin/public/_releaseProgress?releaseId=2596&_a=release-pipeline-progress

@jsuarezruiz jsuarezruiz self-requested a review December 4, 2020 11:40
@jsuarezruiz
Copy link
Contributor

Small changes applied to fix an issue setting the FlyoutBackground (Brush) in iOS:
flyout-brush-fix

@davidortinau davidortinau mentioned this pull request Dec 10, 2020
Open
@PureWeen PureWeen merged commit b340d92 into 5.0.0 Dec 11, 2020
@PureWeen PureWeen deleted the flyout_sizing branch December 11, 2020 12:46
@themronion
Copy link

Finally!)

@samhouts samhouts modified the milestones: 5.0.1, 5.0.0 Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@pictos pictos pictos approved these changes

Assignees
No one assigned
Labels
a/shell 🐚 ControlGallery p/Android p/iOS 🍎 p/UWP
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PureWeen @jsuarezruiz @themronion @pictos @rmarinho @samhouts