Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Shell] Fix query parsing and allow more types for parameters #12186

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • if the destination type isn't a string try to convert it to property type
  • if the parameter is a string url decode it before passing it into the destination
  • Fix an issue where url's passed as parameters was removing too many "/"

Issues Resolved

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

  • This code will url decode the parameter before passed to the VM so the behavior is slightly different. But if the user was already decoding then their decode should be a noop

Testing Procedure

  • unit tests included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho
Copy link
Member

can we make ApplyQueryAttributes public? :)

@PureWeen
Copy link
Contributor Author

PureWeen commented Oct 3, 2020

@rmarinho I think ApplyQueryAttributes is going to go through some changes so probably not now

@PureWeen PureWeen removed the request for review from StephaneDelcroix October 3, 2020 17:06
@PureWeen PureWeen assigned rmarinho and jsuarezruiz and unassigned rmarinho and jsuarezruiz Oct 3, 2020
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Oct 6, 2020
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here on my side, and everything works like a charm

@rmarinho rmarinho merged commit 75a33d2 into 5.0.0 Oct 7, 2020
@rmarinho rmarinho deleted the fix_10899 branch October 7, 2020 14:15
@samhouts samhouts added this to the 5.0.0 milestone Oct 14, 2020
@syedhoque89
Copy link

How do I pass an object (lets a instance of a class or a custom property "Foo") via query params? Some examples would be nice please :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/navigation a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. Core t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Shell] Navigation URL parameter not correctly encoded/decoded
6 participants