Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix MasterBehavior to propagate correctly to FlyoutPage #12727

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Nov 3, 2020

Description of Change

  • Reusing the FlyoutLayoutBehavior Property for MasterBehavior Property was the wrong approach since the types don't match. This creates a new bindable property specific to MasterDetailPage and then propagates that up to FlyoutPage
  • Add copy of all MasterDetailPage tests to FlyoutPage
  • Add ContentPropertyAttribute for Detail on the FlyoutPage type

Issues Resolved

API Changes

Added ContentPropertyAttribute to FlyoutPage

	[RenderWith(typeof(_FlyoutPageRenderer))]
	[ContentProperty("Detail")]
	public class FlyoutPage : Page, IFlyoutPageController, IElementConfiguration<FlyoutPage>
	{

Platforms Affected

  • Core/XAML (all platforms)

Testing Procedure

  • Test various permutations of setting MasterBehavior and make sure that the app reacts accordingly

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added this to the 5.0.0 milestone Nov 3, 2020
@PureWeen PureWeen added 5.0.0 Regression on 5.0.0 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Nov 3, 2020
@PureWeen PureWeen removed the request for review from StephaneDelcroix November 3, 2020 18:57
@rmarinho rmarinho merged commit 454cc53 into 5.0.0 Nov 6, 2020
@rmarinho rmarinho deleted the fix_12490 branch November 6, 2020 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.0.0 Regression on 5.0.0 a/masterdetailpage blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. Core i/regression t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Xamarin.Forms 5 - MasterDetailPage 'Split' behaviour not working anymore
4 participants