Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Build 14393 targets separately #12826

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Build 14393 targets separately #12826

merged 4 commits into from
Nov 16, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

This completely removes the 14393 targets from our csproj files and only builds them as part of our nuget build process. The command line build was also having the same issue building 14393 together with 16299 so this PR just removes the multi targeting completely

Platforms Affected

  • UWP

Testing Procedure

  • Run the build.cmd and ensure that it builds all the nugets

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho
Copy link
Member

Awesome , can build fine on 16.8.1 , also the nuget pack works

image

@rmarinho rmarinho merged commit db8ab0c into 4.8.0 Nov 16, 2020
@rmarinho rmarinho deleted the fix_uwp_168 branch November 16, 2020 12:36
@samhouts samhouts added this to the 5.0.0 milestone Dec 8, 2020
@samhouts samhouts modified the milestones: 5.0.0, 4.8.0 Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants