This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix pushing same page as a modal on iOS13 in split mode #12871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
added
a/modal
p/iOS 🍎
blocker
rmarinho
changed the title
rmarinho
commented
Nov 16, 2020
| @@ -49,9 +49,6 @@ internal ModalWrapper(IVisualElementRenderer modal) | |||
| PresentationController.Delegate = this; | |||
|
|
|||
| ((Page)modal.Element).PropertyChanged += OnModalPagePropertyChanged; | |||
|
|
|||
| if (Forms.IsiOS13OrNewer) | |||
rmarinho
commented
Nov 16, 2020
| modalWrapper.Dispose(); | ||
| } | ||
| #endif | ||
| renderer.NativeView.RemoveFromSuperview(); | ||
| renderer.Dispose(); | ||
| //reset layout size so we can re-layout the layer if we are reusing the same page. | ||
| //fixes a issue on split apps on iPad and iOS13 | ||
| visualElement.Layout(new Rectangle(0, 0, -1, -1)); |
jsuarezruiz
approved these changes
Nov 17, 2020
PureWeen
suggested changes
Nov 20, 2020
There was a problem hiding this comment.
@rmarinho curious your thoughts on this approach.
https://github.com/xamarin/Xamarin.Forms/compare/fix-8988-shane
There might be a better fix is inside VisualElementPackager
Setting the layout bounds to -1 was causing some extra code in VEP to run that basically would set the frame back to the Element bounds. The other curiosity here is why iOS keeps wanting to set the PageContainer.Frame to 526 unprompted :-/ Finding and fixing that might also be a preferred approach though that might just be the SplitView being quirky
|
@PureWeen just tested, and yeah looks a better fix |
PureWeen
approved these changes
Nov 24, 2020
jsuarezruiz
approved these changes
Nov 24, 2020
samhouts
added
i/high
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There's a issue on iOS13 that pushing a modal using your app in split mode, (side by side with other app), it causes issues rendering the second time.
The particular issue is also related with retaining the pushed page , it keeps it's bounds, and we need to force the layout.
Workaround could be to just reset is bounds when is popped.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Go to Issue8988 , click Next, check the page loaded, click Go Back, then click again Next and make sure the page loads fine.
PR Checklist