This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add Shell Resource file explicitly #12954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
blocker
jsuarezruiz
approved these changes
Nov 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With the addition of 14393 we setup the ShellStyles resource file to only get included when Min Target is 16299 and removed the reference from the Resources.xaml file. This appears to work fine if you have target framework set to >= 18632 but if you have it set to 17763 or 16299 then it fails to load the resource.
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist