This repository has been archived by the owner on May 1, 2024. It is now read-only.
[UWP] Fix Button Disabled VisualState #13148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
added a commit
that referenced
this pull request
Feb 3, 2021
2 tasks
|
Any news on when will this be merged to XF? |
|
Is this going to be merged soon please? |
|
When this will be merged? :( |
|
@rachelkang Could you review this PR?. Thanks! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rachelkang
approved these changes
May 10, 2021
|
SR4 broke disabling Buttons via VisualStateManager for me, it was working in 4.8 and till SR3 |
|
@jsuarezruiz any comments on the issue? Your "Fix" broke it when it was working before. |
|
@jsuarezruiz any comments on the issue? It was also reported by a different user in #14428 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Button Disabled VisualState on UWP.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 12984. If the background color of the disabled Button is pink, the test has passed.
PR Checklist