-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Core] Fix Shapes issue using AppThemeBinding #13181
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created this sample based on the original issue and applied the nuget. On Android, it works great. On iOS, it works fine if I rebuild after switching the app theme, but not if I just switch the app theme and then return to the running app. Looks great in CG on both platforms for both scenarios though
Hi @jfversluis , |
@AlleSchonWeg NuGet should be here, let me know if it looks OK to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me!
@jfversluis |
Description of Change
Fix Shapes issue using AppThemeBinding with SolidColorBrush.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 13173. Change between system dark and light theme. If the Rectangle is green with the light theme and red with the dark theme, the test has passed.
PR Checklist