Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Core] Fix Shapes issue using AppThemeBinding #13181

Merged
merged 8 commits into from
Jan 5, 2022
Merged

[Core] Fix Shapes issue using AppThemeBinding #13181

merged 8 commits into from
Jan 5, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Dec 17, 2020

Description of Change

Fix Shapes issue using AppThemeBinding with SolidColorBrush.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • macOS

Behavioral/Visual Changes

None

Before/After Screenshots

fix13173

Testing Procedure

Launch Core Gallery and navigate to the issue 13173. Change between system dark and light theme. If the Rectangle is green with the light theme and red with the dark theme, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added the Core label Jan 15, 2021
@jsuarezruiz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created this sample based on the original issue and applied the nuget. On Android, it works great. On iOS, it works fine if I rebuild after switching the app theme, but not if I just switch the app theme and then return to the running app. Looks great in CG on both platforms for both scenarios though

Issue13093.zip

@AlleSchonWeg
Copy link
Contributor

Hi @jfversluis ,
i ran into this issue. Could we merge this PR in the next SR?
Thank you

@jfversluis
Copy link
Member

@AlleSchonWeg NuGet should be here, let me know if it looks OK to you!

Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me!

@AlleSchonWeg
Copy link
Contributor

@jfversluis
Yes. Works as expected.
Thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.