Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix NRE when using Custom Slide Transition #13494

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Fix NRE when using Custom Slide Transition #13494

merged 2 commits into from
Jan 26, 2021

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jan 21, 2021

Description of Change

ShellFlyoutRenderer wasn't correctly checking for scenarios where users are implementing a Custom Slide Flyout Transition class which was causing an NRE. I've also set the LayoutViews method to be virtual and add made UpdateFlyoutSize public so users can reuse SlideFlyoutTransition

Issues Resolved

API Changes

Added:

public class SlideFlyoutTransition 
     public virtual bool UpdateFlyoutSize(double height, double width)

Changed:

public class SlideFlyoutTransition 
     public virtual void LayoutViews(CGRect bounds, nfloat openPercent, UIView flyout, UIView shell, FlyoutBehavior behavior)

Platforms Affected

  • iOS

Testing Procedure

  • ui test included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jan 21, 2021
@PureWeen PureWeen added this to the 5.0.0 milestone Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/rtl a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SlideFlyoutTransition is not working after the xamarin forms update to xamarin forms 5
4 participants