Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Bump Android X #14101

Merged
merged 9 commits into from
Jun 28, 2021
Merged

Bump Android X #14101

merged 9 commits into from
Jun 28, 2021

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Apr 2, 2021

Description of Change

Bump to latest Android X nugets

Pinned upper bounds of Android X Nugets we've tested against

Users have hit a lot of issues (#13843) upgrading to newer androidx packages that had incompatible APIs from previous versions, so to reduce our maintenance burden we're pinning the upper bounds. We'll continue to bump these up as we release SR's

For example, the latest fragment packages completely broke shell and the new material packages completely broke material

So the range just represents a tested/verified range of packages

If you need to force to higher versions you can modify your csproj file and add them explicitly

<PackageReference Include="Xamarin.Forms" Version="5.0.0.2083" />
<PackageReference Include="Xamarin.AndroidX.Core" Version="1.6.0" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.LiveData" Version="2.3.1" />

Issues Resolved

Platforms Affected

  • Android

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen
Copy link
Contributor Author

PureWeen commented Jun 2, 2021

API 21 is failing ShellItemItemsClearTests_google_pixel_2_8_1_0

@PureWeen PureWeen added DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. and removed DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. labels Jun 2, 2021
@Tommigun1980
Copy link

Will this ever be merged? Android release builds are broken right now as linking fails.

"Mono.Cecil.ResolutionException: Failed to resolve AndroidX.Core.View.Accessibiity.AccessibilityNodeInfoCompat" <-- notice the misspelling.

#13969 was closed but it appears as this hasn't been merged yet so I don't think it's fixed.

Also, imagine new people starting to use XF and builds just won't work for them, wouldn't it make sense to merge this in soon and make a new release? I think that the ability to produce builds is an important feature.

Thank you.

@jsuarezruiz
Copy link
Contributor

This PR will be included in the next Release.

@Tommigun1980
Copy link

This PR will be included in the next Release.

Fantastic, thank you!!

@PureWeen
Copy link
Contributor Author

PureWeen commented Jun 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jamesmontemagno
Copy link
Contributor

Can we align this with the Community Toolkit & Xamarin.Essentials.

@PureWeen
Copy link
Contributor Author

PureWeen commented Jun 8, 2021

Can we align this with the Community Toolkit & Xamarin.Essentials.

@mattleibow @jfversluis @jsuarezruiz ?

FYI this PR is pinning AndroidX upper versions

@Redth Redth merged commit 5e70757 into 5.0.0 Jun 28, 2021
@Redth Redth deleted the bump_androidx branch June 28, 2021 15:09
@MagicAndre1981
Copy link
Contributor

Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.RecyclerView (>= 1.1.0.8 && < 1.2.0) but version Xamarin.AndroidX.RecyclerView 1.2.1 was resolved.	
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.Google.Android.Material (>= 1.2.1.1 && < 1.3.0) but version Xamarin.Google.Android.Material 1.4.0 was resolved.	
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.Lifecycle.LiveData (>= 2.2.0.4 && < 2.3.0) but version Xamarin.AndroidX.Lifecycle.LiveData 2.3.1 was resolved.
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.Core (>= 1.3.2.3 && < 1.4.0) but version Xamarin.AndroidX.Core 1.6.0 was resolved.

Why are the dependencies now restricted in Xamarin.Forms 5.0.0.2083?

@Tommigun1980
Copy link

Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.RecyclerView (>= 1.1.0.8 && < 1.2.0) but version Xamarin.AndroidX.RecyclerView 1.2.1 was resolved.	
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.Google.Android.Material (>= 1.2.1.1 && < 1.3.0) but version Xamarin.Google.Android.Material 1.4.0 was resolved.	
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.Lifecycle.LiveData (>= 2.2.0.4 && < 2.3.0) but version Xamarin.AndroidX.Lifecycle.LiveData 2.3.1 was resolved.
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.Core (>= 1.3.2.3 && < 1.4.0) but version Xamarin.AndroidX.Core 1.6.0 was resolved.

Why are the dependencies now restricted in Xamarin.Forms 5.0.0.2083?

The commit that introduced that says just “fix versioning”: fbb37d9

Maybe create a bug report for better visibility?

@AndreasReitberger
Copy link

Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.RecyclerView (>= 1.1.0.8 && < 1.2.0) but version Xamarin.AndroidX.RecyclerView 1.2.1 was resolved.	
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.Google.Android.Material (>= 1.2.1.1 && < 1.3.0) but version Xamarin.Google.Android.Material 1.4.0 was resolved.	
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.Lifecycle.LiveData (>= 2.2.0.4 && < 2.3.0) but version Xamarin.AndroidX.Lifecycle.LiveData 2.3.1 was resolved.
Warning	NU1608	Detected package version outside of dependency constraint: Xamarin.Forms 5.0.0.2083 requires Xamarin.AndroidX.Core (>= 1.3.2.3 && < 1.4.0) but version Xamarin.AndroidX.Core 1.6.0 was resolved.

Why are the dependencies now restricted in Xamarin.Forms 5.0.0.2083?

I created an issue for this.
#14417

rotorgames pushed a commit to rotorgames/Xamarin.Forms that referenced this pull request Dec 9, 2021
* Bump a few Android X projects to fix incompatibilities

* Update DualScreen.Android.csproj

* - pin androidx versions

* - fix versioning

* - workaround fragment life cycle changes

* - remove content from page before re-using

* - fix accessibility namespaces

* - bump browser and pin Navigation.UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android.content.res.Resources$NotFoundException: Unable to find resource ID #0xffffffff
7 participants