This repository has been archived by the owner on May 1, 2024. It is now read-only.
added missing iOS constructor in ListViewRenderer #14971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added a missing constructor in ListViewRenderer
Issues Resolved
Could not find it. But I saw it in the app crash logs:
ObjCRuntime.RuntimeException
Failed to marshal the Objective-C object 0x28382b600 (type: Xamarin_Forms_Platform_iOS_ListViewRenderer_ListViewDataSource). Could not find an existing managed instance for this object, nor was it possible to create a new managed instance (because the type 'Xamarin.Forms.Platform.iOS.ListViewRenderer+ListViewDataSource' does not have a constructor that takes one IntPtr argument).
API Changes
Added:
Platforms Affected
Behavioral/Visual Changes
By having that missing constructor, we avoid that exception
Testing Procedure
I saw it in our crash logs.
Don't know necessarily how to reproduce it.
PR Checklist