This repository has been archived by the owner on May 1, 2024. It is now read-only.
Make sure ScrollViewRenderer on Android is resolving layout changes #15076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and verified to fix #14918 as well, thanks. 👍 |
|
Thanks @radioactiveman ! |
jsuarezruiz
approved these changes
Jan 24, 2022
This was referenced Jan 24, 2022
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ScrollViewRenderer does not inherit from VisualElementRenderer, it was not inheriting the override which resolves layout changes before a measure/layout pass.
This change overrides OnMeasure to handle that.
Fixes #15066
Proposing this as an alternative to #15067.