This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix NRE in iOS ImageRenderer #15117
Merged
Fix NRE in iOS ImageRenderer #15117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are seeing this crash in production, when might this be available in an XF SR? |
|
@JohnHDev I'm preparing it right now. Hopefully this week, but might be early next week. Although not recommended, the binaries should show up on the releases page here on GitHub early. You could grab those if you really need it now. Unless we find something really wrong with it, it should be the exact same version that ends up on NuGet. |
|
@jfversluis when might this be released? We are using the custom renderer solution at the moment but would like to remove that when the fix is released. |
|
I understand, that is what we want as well of course :) working hard on it! My hope is early next week |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Missing null check in #14797 causes a NRE in certain scenarios
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots ### ese changes were made and another screenshot after the changes were made to show possible visual changes. -->
Not applicable
Testing Procedure
PR Checklist