This repository has been archived by the owner on May 1, 2024. It is now read-only.
Comparing Enum to Object crashes ItemComparer #15263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When valueA passed to ItemComparer is and Enum and valueB is an object, the Enum.CompareTo will throw an exception. Sample: var a=FooEnum.One; var b = new CrazyObject(); ItemComparer.AreEquals(a,b); // -> ArgumentException: Object must be the same type as the enum. The type passed in was 'CrazyObject'; the enum type was 'FooEnum'.
|
Bug #15264 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When an different types are used via Bindings on a Collectionview the ItemComparer can crash the application.
Issues Resolved
When valueA passed to ItemComparer is and Enum and valueB is an object, the Enum.CompareTo will throw an exception.
Sample:
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None (no Exception in Renderer, thus no crash)
Before/After Screenshots
Not applicable
Testing Procedure
See Code sample above, code can be unittested.
PR Checklist