Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Replace XmlnsSupportsValidationAttribute #15855

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Replace XmlnsSupportsValidationAttribute #15855

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
596c3dd
Replace XmlnsSupportsValidationAttribute
jfversluis Jan 25, 2024
8863ce0
Add references
jfversluis Jan 25, 2024
5a24df3
Remove Microsoft.Windows.Design.Extensibility ref
jfversluis Jan 25, 2024
2706875
Revert "Remove Microsoft.Windows.Design.Extensibility ref"
jfversluis Jan 25, 2024
df18342
Testing something out
jfversluis Jan 25, 2024
ddd782a
Update Xamarin.Forms.Core.Design.csproj
jfversluis Jan 25, 2024
0c6d168
Update Xamarin.Forms.Core.Design.csproj
jfversluis Jan 25, 2024
c6a7ee0
PR Feedback
jfversluis Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,4 @@ Visual Studio 2019/**
TestResult.xml
build/packages
WriteDevopsVariables.csproj
!Microsoft.VisualStudio.DesignTools.Extensibility.dll
3 changes: 1 addition & 2 deletions Xamarin.Forms.Core.Design/AttributeTableBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
using System;
using System.ComponentModel;
using System.Linq;
using System.Windows.Markup;
using Microsoft.Windows.Design;
using Microsoft.VisualStudio.DesignTools.Extensibility;
jfversluis marked this conversation as resolved.
Show resolved Hide resolved
using Xamarin.Forms.Internals;

namespace Xamarin.Forms.Core.Design
Expand Down
6 changes: 6 additions & 0 deletions Xamarin.Forms.Core.Design/Xamarin.Forms.Core.Design.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@
<Compile Include="KeyboardDesignTypeConverter.cs" />
<Compile Include="EasingDesignTypeConverter.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="Microsoft.VisualStudio.DesignTools.Extensibility, Version=17.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\Xamarin.Forms.Xaml.Design\Microsoft.VisualStudio.DesignTools.Extensibility.dll</HintPath>
</Reference>
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<!-- Ensure that all images in the 'mac' and 'win' subdirectories are included as embedded resources -->
<!-- using a defined format. That format is "{platform}.{imagename}". We will look up images using -->
Expand Down
3 changes: 1 addition & 2 deletions Xamarin.Forms.Xaml.Design/AttributeTableBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.ComponentModel;
using Microsoft.Windows.Design;
using Microsoft.VisualStudio.DesignTools.Extensibility;

namespace Xamarin.Forms.Xaml.Design
{
Expand Down
Binary file added Xamarin.Forms.Xaml.Design/Microsoft.VisualStudio.DesignTools.Extensibility.dll
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions Xamarin.Forms.Xaml.Design/Xamarin.Forms.Xaml.Design.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,11 @@
<Private>False</Private>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<Reference Include="Microsoft.VisualStudio.DesignTools.Extensibility, Version=17.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>.\Microsoft.VisualStudio.DesignTools.Extensibility.dll</HintPath>
</Reference>
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
</Project>