This repository has been archived by the owner on May 1, 2024. It is now read-only.
[XamlC] Cache Resolve and ImportReference #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportReference with System.Reflection based argument is notoriously slow on .NET. So we cache the results for those. We do not cache the results for TypeReference, MethodReference or FieldReference calls, as those are already fast (passthrough if the reference was already imported), and they aren't valid as dictionary keys (no concept of equatability). While we're at it, we shave another few ms from Resolve(TypeReference) calls as well. As, on good days, it shaves up to 40% of XamlC time, we can say that it - fixes #1848
Seeeems good |
jassmith
approved these changes
Feb 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[XamlC] Cache Resolve and ImportReference
ImportReference with System.Reflection based argument is notoriously
slow on .NET. So we cache the results for those.
We do not cache the results for TypeReference, MethodReference or
FieldReference calls, as those are already fast (passthrough if the
reference was already imported), and they aren't valid as dictionary
keys (no concept of equatability).
While we're at it, we shave another few ms from Resolve(TypeReference)
calls as well.
As, on good days, it shaves up to 40% of XamlC time, we can say that it fixes #1848
Bugs Fixed
PR Checklist