This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Handle creating a default GroupHeader if no GroupHeaderTemplate is provided #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| namespace Xamarin.Forms.Controls | ||
| { | ||
| [Preserve(AllMembers = true)] | ||
| [Issue(IssueTracker.Github, 55555, "Header problem")] |
There was a problem hiding this comment.
Probably should be IssueTracker.None, but not a big deal.
rmarinho
force-pushed
the
fix-groupdisplayandroid
branch
from
821833f
to
ffefa6c
Compare
|
@rmarinho, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
👍 with passing UI tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the user is using the RecycleElement strategy we don't really on the TIL cells, so we handle creating the group header cell on the platform side.
We weren't handling the case where no template was provided, (user provided the GroupDisplayPath).
This change makes sure we create the default group header and set the attached property so we know is a groupheader.
PR Checklist