This repository has been archived by the owner on May 1, 2024. It is now read-only.
Implement CollectionView grouping on Android #7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Android API19 and 28 test failures are unrelated. |
jfversluis
approved these changes
Aug 20, 2019
Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com>
|
UI tests failures are unrelated. |
samhouts
approved these changes
Aug 28, 2019
Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs
Outdated
Show resolved
Hide resolved
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Move all the header/footer adjustment to IItemsViewSource fixes xamarin#7121 fixes xamarin#7102 partially implements xamarin#3172 fixes xamarin#7243 * Fix selection bugs introduced by header/footer on Android * Implement grouping for CollectionView on Android * Enable grouping tests for Android * Naming and comment cleanup * Update Xamarin.Forms.Platform.Android/CollectionView/ListSource.cs Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com> * Update Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Move all the header/footer adjustment to IItemsViewSource fixes xamarin#7121 fixes xamarin#7102 partially implements xamarin#3172 fixes xamarin#7243 * Fix selection bugs introduced by header/footer on Android * Implement grouping for CollectionView on Android * Enable grouping tests for Android * Naming and comment cleanup * Update Xamarin.Forms.Platform.Android/CollectionView/ListSource.cs Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com> * Update Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implements grouping for the CollectionView on Android.
Also cleans up some selection errors and crashes introduced by headers/footers on Android.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated tests
PR Checklist