This repository has been archived by the owner on May 1, 2024. It is now read-only.
Finish ScrollTo implementations for CollectionView on UWP #7509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
reviewed
Sep 17, 2019
|
|
||
| static bool IsVertical(ScrollViewer scrollViewer) | ||
| { | ||
| return scrollViewer.HorizontalScrollMode == ScrollMode.Disabled; |
There was a problem hiding this comment.
Note entirely up-to-date with UWP but is this enough to determine with certainty that it's vertical? There is also a VerticalScrollMode, don't we need to use that or at least get that into the equation?
jfversluis
suggested changes
Sep 17, 2019
There was a problem hiding this comment.
Code looks good, but:
- Build failing on failing unit test? Seems unrelated but weird that it suddenly decides to fail
- Having a quick play with it I found a NRE in the Gallery app.
- Go to the CollectionView -> ScrollTo gallery -> ScrollTo Index (Code, Horizontal List) which is the first option
- Input 42 in Scroll To Index box and click Go
- Now click Advance (nothing happens, although the index in the middle updates)
- Keep clicking Advance until you go past the number of items in the collection and watch the fireworks
Same thing happens on the Vertical list and grid and... which might not be surprising
hartez
force-pushed
the
cv-uwp-scrollto
branch
from
ff00154
to
c678483
Compare
Rebased on Shane's fixes to the unit tests, should be working now.
Nothing should happen, if the ScrollToPosition is set to MakeVisible, because the next items are already visible.
Yep, IndexOutOfRange issue. Should be fixed now. |
jfversluis
approved these changes
Sep 18, 2019
rmarinho
approved these changes
Sep 20, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…) partially implements xamarin#3172 * Finish ScrollTo implementations for CollectionView on UWP * Fix NRE when attempting to scroll to index greater than source length
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…) partially implements xamarin#3172 * Finish ScrollTo implementations for CollectionView on UWP * Fix NRE when attempting to scroll to index greater than source length
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implements missing ScrollTo features for CollectionView on UWP.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
In Control Gallery, navigate to CollectionView Gallery -> ScrollTo Gallery and run everything.
PR Checklist