This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Bug] [iOS] platform-specific VisualElement Blur is misaligned #9732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiMisiukevich
changed the title
AndreiMisiukevich
changed the title
AndreiMisiukevich
force-pushed
the
fix_9720
branch
from
aa1730b
to
d986d18
Compare
|
@samhouts I rebased onto 4.6.0 |
|
@AndreiMisiukevich Actually, the blur is supposed to be on the superview. Weird, right? But that's how the blur effect on was documented on iOS at the time we added the platform specific. As you can see in our documentation, we expect the blur effect to blur the content beneath the view you've added the effect to. https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/visualelement-blur |
AndreiMisiukevich
force-pushed
the
fix_9720
branch
from
fc74922
to
4ca512d
Compare
AndreiMisiukevich
force-pushed
the
fix_9720
branch
from
4ca512d
to
a433c74
Compare
|
@samhouts I updated my PR. Please re-review |
|
@samhouts should I retarget my PR to master? |
|
@samhouts seems nobody is assigned as a reviewer to this PR |
samhouts
added
the
retarget-branch-required
|
retarget completed |
|
/azp run |
|
No pipelines are associated with this pull request. |
rmarinho
approved these changes
Aug 13, 2020
myroot
pushed a commit
to myroot/Xamarin.Forms
that referenced
this pull request
Aug 19, 2020
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add blur effect view to the view instead of view's superview. (I assume it's a mistake/typo)
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
The blur effect has the same coordinates with the view that it's applied for.
Before/After Screenshots
BEFORE:
AFTER:
Testing Procedure
The sample is attached in the original bug ticket.