Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

fix TabViewIndicator position on RTL #1983

Closed
wants to merge 1 commit into from

Conversation

Tarekka
Copy link

@Tarekka Tarekka commented Aug 28, 2023

Description of Bug

TabView - TabViewIndicator goes off the screen when flow direction is RTL. This is caused by the UpdateTabIndicatorPosition method not taking RTL into consideration when calculating the position to translate the indicator to.

Issues Fixed

Behavioral Changes

PR Checklist

  • Has a linked Issue, and the Issue has been approved
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@jfversluis
Copy link
Member

Now that we're so close to the sunsetting of Xamarin (and therefore also Xamarin Community Toolkit) unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR, we really appreciate it.

Please have a look at the evolution of the Xamarin Community Toolkit, The .NET MAUI Community Toolkit. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin user!

@jfversluis jfversluis closed this Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TabView - TabIndicator doesn't show when flow direction is RTL
2 participants