Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[passkit] Update for Xcode 12 beta 4 #9218

Merged
merged 7 commits into from
Aug 18, 2020
Merged

[passkit] Update for Xcode 12 beta 4 #9218

merged 7 commits into from
Aug 18, 2020

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented Jul 28, 2020 •
edited
Loading

No description provided.

[passkit] Update for Xcode 12 beta 3
4e9fbf7 
note: macOS is new and unreviewed (hence the draft PR)

I'll pick it up later (once back) but wanted it out in case someone
needs it (and wants to complete it) before then :)
@spouliot spouliot added the do-not-merge Do not merge this pull request label Jul 28, 2020
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

6 tests failed, 70 tests passed.

Failed tests

  • apitest/Mac Modern/Debug: Failed (Test run failed.)
  • introspection/Mac Modern/Debug: Failed (Test run failed.)
  • apitest/Mac Full/Debug: Failed (Test run failed.)
  • introspection/iOS Unified 64-bits - simulator/Debug: Failed
  • introspection/watchOS 32-bits - simulator/Debug: Failed
  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 10.3): Failed

rolfbjarne
rolfbjarne requested changes Jul 29, 2020
View reviewed changes
src/passkit.cs Show resolved Hide resolved
src/passkit.cs Show resolved Hide resolved
src/passkit.cs Show resolved Hide resolved
src/passkit.cs Outdated Show resolved Hide resolved
src/passkit.cs Outdated Show resolved Hide resolved
@spouliot spouliot added this to the xcode12 milestone Jul 29, 2020
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

7 tests failed, 69 tests passed.

Failed tests

  • apitest/Mac Modern/Debug: Failed (Test run failed.)
  • introspection/Mac Modern/Debug: Failed (Test run failed.)
  • apitest/Mac Full/Debug: Failed (Test run failed.)
  • Xtro/Mac: HarnessException (Harness exception for 'Xtro': System.NullReferenceException: Object reference not set to an instance of an object
    at Xharness.TestTasks.RunTest.BuildAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/TestTasks/RunTest.cs:71
    at Xharness.TestTasks.RunTest.ExecuteAsync () [0x000d8] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/TestTasks/RunTest.cs:95
    at Microsoft.DotNet.XHarness.iOS.Shared.Tasks.TestTasks.RunInternalAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/TestTask.cs:282 )
  • introspection/iOS Unified 64-bits - simulator/Debug: Failed
  • introspection/watchOS 32-bits - simulator/Debug: Failed
  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 10.3): Failed

@spouliot spouliot changed the title [passkit] Update for Xcode 12 beta 3 [passkit] Update for Xcode 12 beta 4 Aug 14, 2020
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 78 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@spouliot
Copy link
Contributor Author

failure due to https://github.com/xamarin/maccore/issues/2154

@spouliot spouliot marked this pull request as ready for review August 14, 2020 17:12
@spouliot spouliot requested a review from chamons as a code owner August 14, 2020 17:12
@spouliot spouliot removed the do-not-merge Do not merge this pull request label Aug 14, 2020
dalexsoto
dalexsoto approved these changes Aug 14, 2020
View reviewed changes
src/passkit.cs Outdated
[Export ("currencyCode")]
string CurrencyCode { get; }

// FIXME ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Should we create an issue? or list it in our bucket for review issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove the FIXME
Other places (where amount is defined, in PassKit and elsewhere) uses NSDecimalNumber which is a subclass of NSNumber so we can't bind it as such.

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 78 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

rolfbjarne
rolfbjarne requested changes Aug 17, 2020
View reviewed changes
src/passkit.cs Outdated Show resolved Hide resolved
src/passkit.cs Outdated Show resolved Hide resolved
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 77 tests passed.

Failed tests

  • Xtro/Mac: HarnessException (Harness exception for 'Xtro': System.NullReferenceException: Object reference not set to an instance of an object
    at Xharness.TestTasks.RunTest.BuildAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/TestTasks/RunTest.cs:71
    at Xharness.TestTasks.RunTest.ExecuteAsync () [0x000d8] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/TestTasks/RunTest.cs:95
    at Microsoft.DotNet.XHarness.iOS.Shared.Tasks.TestTasks.RunInternalAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/TestTask.cs:282 )
  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 78 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@spouliot
Copy link
Contributor Author

Test failure is a known issue -> https://github.com/xamarin/maccore/issues/2154

@spouliot spouliot merged commit e7d605c into xamarin:xcode12 Aug 18, 2020
@spouliot spouliot deleted the xcode12-passkit-b3 branch August 18, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@chamons chamons Awaiting requested review from chamons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
xcode12
Development

Successfully merging this pull request may close these issues.
5 participants
@spouliot @monojenkins @dalexsoto @rolfbjarne @whitneyschmidt