Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppTrackingTransparency] Add support for Xcode 12 beta 4 #9385

Merged
merged 6 commits into from
Aug 19, 2020
Merged

[AppTrackingTransparency] Add support for Xcode 12 beta 4 #9385

merged 6 commits into from
Aug 19, 2020

Conversation

dottam
Copy link
Contributor

@dottam dottam commented Aug 17, 2020

No description provided.

@dnfadmin
Copy link

dnfadmin commented Aug 17, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

rolfbjarne
rolfbjarne approved these changes Aug 17, 2020
View reviewed changes
src/Constants.mac.cs.in Outdated Show resolved Hide resolved
@rolfbjarne
Copy link
Member

build

@rolfbjarne rolfbjarne added the community Community contribution ❤ label Aug 17, 2020
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 77 tests passed.

Failed tests

  • Xtro/Mac: HarnessException (Harness exception for 'Xtro': System.NullReferenceException: Object reference not set to an instance of an object
    at Xharness.TestTasks.RunTest.BuildAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/TestTasks/RunTest.cs:71
    at Xharness.TestTasks.RunTest.ExecuteAsync () [0x000d8] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/TestTasks/RunTest.cs:95
    at Microsoft.DotNet.XHarness.iOS.Shared.Tasks.TestTasks.RunInternalAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/TestTask.cs:282 )
  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

mandel-macaque
mandel-macaque approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!!!!!!!

@spouliot
Copy link
Contributor

Xtro/Mac failed because the files

  • tests/xtro-sharpie/iOS-AppTrackingTransparency.todo
  • tests/xtro-sharpie/tvOS-AppTrackingTransparency.todo
  • tests/xtro-sharpie/macOS-AppTrackingTransparency.todo

needs to be deleted, as the todo items have been completed by this PR. This is (part of) how we track the remaining work for new Xcode releases.

The other failure is a known (network) random issue. No need to worry about it for this PR.

@mandel-macaque
Copy link
Member

@spouliot on my side, I updated the wiki status to point to this PR: https://github.com/xamarin/xamarin-macios/wiki/xcode12-Bindings-Status/2010ff8f7fd69339ee0c987df93ed1424da2a38e

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 17, 2020
dalexsoto
dalexsoto approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

@dalexsoto
Copy link
Member

build

@dottam
Copy link
Contributor Author

dottam commented Aug 17, 2020

Xtro/Mac failed because the files

  • tests/xtro-sharpie/iOS-AppTrackingTransparency.todo
  • tests/xtro-sharpie/tvOS-AppTrackingTransparency.todo
  • tests/xtro-sharpie/macOS-AppTrackingTransparency.todo

needs to be deleted, as the todo items have been completed by this PR. This is (part of) how we track the remaining work for new Xcode releases.

The other failure is a known (network) random issue. No need to worry about it for this PR.

The files has been removed

@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

@dalexsoto
Copy link
Member

build

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 77 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@mandel-macaque
Copy link
Member

mandel-macaque commented Aug 18, 2020 •
edited
Loading

Mtouch tests can be ignored, they are a known issue and I'm looking into it: https://github.com/xamarin/maccore/issues/1028

@dottam the xtro tests are easy to fix the following fields do not need to be bounds

!missing-field! AppTrackingTransparencyVersionNumber not bound
!missing-field! AppTrackingTransparencyVersionString not bound

You can create a common-AppTrackingTransparency.ignore file under the xtro directory and add those two warnings. For references, something similar to the following: https://github.com/xamarin/xamarin-macios/pull/9391/files#diff-72f0a3c765f74fd37f627a3bfbbd5efdR1

Once that is done, we are landing this :)

@dottam
Copy link
Contributor Author

dottam commented Aug 19, 2020

Mtouch tests can be ignored, they are a known issue and I'm looking into it: xamarin/maccore#1028

@dottam the xtro tests are easy to fix the following fields do not need to be bounds

!missing-field! AppTrackingTransparencyVersionNumber not bound
!missing-field! AppTrackingTransparencyVersionString not bound

You can create a common-AppTrackingTransparency.ignore file under the xtro directory and add those two warnings. For references, something similar to the following: https://github.com/xamarin/xamarin-macios/pull/9391/files#diff-72f0a3c765f74fd37f627a3bfbbd5efdR1

Once that is done, we are landing this :)

I've added the common-AppTrackingTransparency.ignore file

@rolfbjarne
Copy link
Member

build

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

5 tests failed, 74 tests passed.

Failed tests

  • apitest/Mac Modern/Debug: BuildFailure
  • introspection/Mac Modern/Debug: BuildFailure
  • apitest/Mac Full/Debug: BuildFailure
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 1)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@rolfbjarne
Copy link
Member

Test failures are unrelated

@rolfbjarne rolfbjarne merged commit 3dad70a into xamarin:xcode12 Aug 19, 2020
@rolfbjarne
Copy link
Member

Thanks a lot for your contribution!

@pperera
Copy link

pperera commented Aug 19, 2020

Thanks @dottam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

@chamons chamons Awaiting requested review from chamons

Assignees
No one assigned
Labels
community Community contribution ❤ note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dottam @dnfadmin @rolfbjarne @monojenkins @spouliot @mandel-macaque @dalexsoto @pperera @whitneyschmidt