[xcode12] [Foundation] Fix NSUrl's implicit Uri operators. Fixes #9607. #9611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Uri.PathAndQuery is not allowed on a relative Uri, which made the previous Uri -> NSUrl implicit operator always throw if given a relative NSUrl. So I fixed that, added several tests, and found another issue (it turns out that 'url.RelativePath == url.Path' is not a reliable way to detect absolute urls, because it's true for relative urls as well) and fixed that too. Fixes xamarin#9607.
rolfbjarne
approved these changes
Sep 10, 2020
|
Build success |
dalexsoto
approved these changes
Sep 10, 2020
spouliot
approved these changes
Sep 11, 2020
tj-devel709
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling Uri.PathAndQuery is not allowed on a relative Uri, which made the
previous Uri -> NSUrl implicit operator always throw if given a relative
NSUrl.
So I fixed that, added several tests, and found another issue (it turns out
that 'url.RelativePath == url.Path' is not a reliable way to detect absolute
urls, because it's true for relative urls as well) and fixed that too.
Fixes #9607.
Backport of #9610.
/cc @rolfbjarne