Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Commit

Permalink
crypto: lib/mpi - avoid null pointer deref in mpi_cmp_ui()
Browse files Browse the repository at this point in the history
During NVMeTCP Authentication a controller can trigger a kernel
oops by specifying the 8192 bit Diffie Hellman group and passing
a correctly sized, but zeroed Diffie Hellamn value.
mpi_cmp_ui() was detecting this if the second parameter was 0,
but 1 is passed from dh_is_pubkey_valid(). This causes the null
pointer u->d to be dereferenced towards the end of mpi_cmp_ui()

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
shiftee authored and herbertx committed Aug 11, 2023
1 parent 2a598d0 commit 9e47a75
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions lib/crypto/mpi/mpi-cmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,12 @@ int mpi_cmp_ui(MPI u, unsigned long v)
mpi_limb_t limb = v;

mpi_normalize(u);
if (!u->nlimbs && !limb)
return 0;
if (u->nlimbs == 0) {
if (v == 0)
return 0;
else
return -1;
}
if (u->sign)
return -1;
if (u->nlimbs > 1)
Expand Down

0 comments on commit 9e47a75

Please sign in to comment.