-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reserved identifier violation #10
Comments
will fix by removing the underscores from all headers |
@elfring are you actually using this package or just making sure it fits a set of style guidelines? |
Some uses of double underscores should also be reconsidered, shouldn't it? Can C standard-compliance help you to reduce the error probability around specific implementation details? |
isn't that c++ ? |
Thanks for your improvement of affected include guards. There are a few update candidates left over. |
but those are macro arguments ... I think there is no point in changing those since their scope is limited to the actual macro implementation. Is this being reported by some analyzer? |
Macro arguments are also identifiers. Would you like to clean-up the remaining source code places which tamper still with the reserved name space? |
Some identifiers did not fit to the expected naming convention of the C language standard. https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier This detail was fixed by the deletion of leading underscores. A few macro parameters were enclosed by additional parentheses. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
I would like to point out that identifiers like "
__tagged_value
" and "_HL_HASHTABLE_H_
" do eventually not fit to the expected naming convention of the C language standard.Would you like to adjust your selection for unique names?
The text was updated successfully, but these errors were encountered: