Update integrations 1/2 #1925
Merged
Update integrations 1/2 #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
May 4, 2024
There was a problem hiding this comment.
Hi @jmajaca, thanks for your PR. Looks good, except for removing the GitLabCI and HipChat services.
Removing those means that people who use older versions of GitLab can no longer update this package.
So I prefer to keep those services in for now...
|
@svanharmelen I returned deleted services back to the source code. I also left URLs in function docs unchanged (and broken) because the oldest official gitlab docs archive is version 14.7 and it seems that those services were removed before that. |
svanharmelen
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated first 10 (out of 20) integrations that are currently implemented in the source code - Integrations API.
gitlab-ciandhipchatare no longer in the API docs so I deleted them.My idea is to update remaining 10 in the next PR.