Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message-switch, message-switch-unix: port to safe-strings without changing the interface #41

Merged
merged 3 commits into from
May 22, 2018

Conversation

mseri
Copy link
Collaborator

@mseri mseri commented May 22, 2018

In the few places where we use unsafe coercions, you can easily track the ownership of the bytes. They are always contained around the block that deals with them

Marcello Seri added 2 commits May 22, 2018 11:01
The lifetime of the buffers is well contained in the calling
blocks, so we can use unsafe coercions most of the times.

Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
The lifetime of the buffers is well contained in the calling
blocks, so we can use unsafe coercions most of the times.

Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
@mseri mseri merged commit 4f2df23 into xapi-project:master May 22, 2018
edwintorok pushed a commit to edwintorok/message-switch that referenced this pull request Sep 20, 2021
CA-336056: off-host xe wasn't working when run as non-root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants