(master) CA-134784: Fix race conditions in refcounter #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 2b9bfe8fc32763b97518d406c3e7589d1df914dc on matelakat:CA-134784 into * on xapi-project:master*. |
matelakat
changed the title
Concurrent refcounter operations on two different refcounters sharing
the same namespace can lead to race conditions:
A.) By the time the refcounter file is written, the namespace directory
has already been removed
B.) Removing a namespace directory fails, because a a new refcounter file
has been created within the same directory
_writeCount now returns False if the file was not found
A is solved by spinning on _writeCount until it succeeds.
B is solved by ignoring the errors
Signed-off-by: Mate Lakat <mate.lakat@citrix.com>
|
Changes Unknown when pulling 62caa19 on matelakat:CA-134784 into * on xapi-project:master*. |
|
Closing it down as the change does not include unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent refcounter operations on two different refcounters sharing
the same namespace can lead to race conditions:
A.) By the time the refcounter file is written, the namespace directory
has already been removed
B.) Removing a namespace directory fails, because a a new refcounter file
has been created within the same directory
_writeCount now returns False if the file was not found
A is solved by spinning on _writeCount until it succeeds.
B is solved by ignoring such situations.
Signed-off-by: Mate Lakat mate.lakat@citrix.com