CA-128095 #238
Closed
CA-128095 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this please |
|
Acked-by: Germano Percossi germano.percossi@citrix.com |
|
OK, back on this after quite some time :-) The raise in there is too drastic. Just check that at the end of the block we have at least one session and if not, raise a generic iscsi failure. I think this is the simplest and lest invasive thing we can do |
germanop
suggested changes
Apr 4, 2017
drivers/LVHDoISCSISR.py
Outdated
| @@ -153,6 +153,7 @@ def load(self, sr_uuid): | |||
| self.session.xenapi.PBD.set_device_config(pbd, dconf) | |||
| except: | |||
| util.logException("LVHDoISCSISR.load") | |||
| raise | |||
There was a problem hiding this comment.
raising here has many unwanted effects.
Let's just raise if we did not manage to have any valid session (the reason why the next indexing fails).
There is a big try/except block in load() that does not handle all possible exceptions. If an exception is not handled in place, it is logged and the function tries to continue immediately after the try/except block. Some errors are recoverable further down, but not all. When an exception is thrown, log it and save it; if immediatelly after the try/except block an 'IndexError' exception is raised, catch it and throw an 'SROSError' one instead. Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com> Reviewed-by: Germano Percossi <germano.percossi@citrix.com>
kostaslambda
force-pushed
the
CA-128095
branch
3 times, most recently
from
a96b9ea
to
585583b
Compare
Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com> Reviewed-by: Germano Percossi <germano.percossi@citrix.com>
|
Superseded by PR-358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.