CA-159585: Fix broken travis-CI for SM #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of out travis use, we do a pylint check on new pull requests. Recently, as of pylint(v1.4) support for python 2.6 has been dropped. Also, pylint uses `astroid` as an external dependency who's changes have also broken support for python2.6. Since we use python 2.7 on trunk, we should drop testing our patches on python 2.6 and switch to 2.7. Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
|
Changes Unknown when pulling bab0cce on siddharthv:CA-159585 into * on xapi-project:master*. |
|
Looks good. Please merge to staging branch. |
robertbreker
pushed a commit
to robertbreker/sm
that referenced
this pull request
Mar 2, 2015
As part of out travis use, we do a pylint check on new pull requests. Recently, as of pylint(v1.4) support for python 2.6 has been dropped. Also, pylint uses `astroid` as an external dependency who's changes have also broken support for python2.6. Since we use python 2.7 on trunk, we should drop testing our patches on python 2.6 and switch to 2.7. Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com> Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xapi-project#245 on xapi-project/sm
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
As part of out travis use, we do a pylint check on new pull requests. Recently, as of pylint(v1.4) support for python 2.6 has been dropped. Also, pylint uses `astroid` as an external dependency who's changes have also broken support for python2.6. Since we use python 2.7 on trunk, we should drop testing our patches on python 2.6 and switch to 2.7. Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xapi-project#245 on xapi-project/sm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of out travis use, we do a pylint check on new pull requests.
Recently, as of pylint(v1.4) support for python 2.6 has been dropped.
Also, pylint uses
astroidas an external dependency who's changes havealso broken support for python2.6.
Since we use python 2.7 on trunk, we should drop testing our patches on
python 2.6 and switch to 2.7.
Signed-off-by: Siddharth Vinothkumar siddharth.vinothkumar@citrix.com