CA-92675: Change ISCSI SR scheduler to NOOP #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ISCSI SR works on a LUNperVDI model, attaching a single LUN to a guest directly via blkback (or tapdisk, in the Rackspace case). Given that a single task will be issuing requests at any time, it does not make sense to use the CFQ scheduler for the underlying block devices. This patch changes the block device (or all block devices, for the multipath cases, including the device mapper) scheduler(s) to "noop" for the LUNs related to the SR. Signed-off-by: Felipe Franciosi <felipe@paradoxo.org>
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
The ISCSI SR works on a LUNperVDI model, attaching a single LUN to a guest directly via blkback (or tapdisk, in the Rackspace case). Given that a single task will be issuing requests at any time, it does not make sense to use the CFQ scheduler for the underlying block devices. This patch changes the block device (or all block devices, for the multipath cases, including the device mapper) scheduler(s) to "noop" for the LUNs related to the SR. Reviewed-by: Stefano Panella <stefano.panella@citrix.com> GitHub: closes xapi-project#253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ISCSI SR works on a LUNperVDI model, attaching a single LUN to a guest
directly via blkback (or tapdisk, in the Rackspace case). Given that a single
task will be issuing requests at any time, it does not make sense to use the
CFQ scheduler for the underlying block devices.
This patch changes the block device (or all block devices, for the multipath
cases, including the device mapper) scheduler(s) to "noop" for the LUNs
related to the SR.
Signed-off-by: Felipe Franciosi felipe@paradoxo.org