CA-173498: Fix match_targetIQN in iscsilib #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation use `re` to match IQNs from iscsiadm's output. This would break in cases where the iqn's are substrings of each other. This patch extracts the iqn from the output of iscsiadm and compares it with the targetIQN. Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
The current implementation use `re` to match IQNs from iscsiadm's output. This would break in cases where the iqn's are substrings of each other. This patch extracts the iqn from the output of iscsiadm and compares it with the targetIQN. Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xapi-project#263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses
reto match IQNs from iscsiadm'soutput. This would break in cases where the iqn's are substrings of each
other.
This patch extracts the iqn from the output of iscsiadm and compares it
with the targetIQN.
Signed-off-by: Siddharth Vinothkumar siddharth.vinothkumar@citrix.com