Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA-136041: Multipathd forgets faulty paths after an SR operation #274

Closed
wants to merge 1 commit into from
Closed

CA-136041: Multipathd forgets faulty paths after an SR operation #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions drivers/mpath_dmp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,22 @@ def _resetDMP(sid,explicit_unmap=False,delete_nodes=False):
except:
util.SMlog("WARNING: exception raised while attempting to"
" modify multipath.conf")
try:

# Overriding delete_nodes value to True, since reconfigure does not drop
# devices that are faulty during pbd unplug and plug. They remain
# the system which prevents creation of new maps. This setting is valid only
# for any SR operation done before dev_loss_tmo, post which the device is
# automatically dropped by the kernal.

delete_nodes=True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot force this behaviour ignoring what is passed to the function

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is mitigating the problem with multipath reconfigure this will force us to rescan the bus
every time we need those paths.
This is an expensive operation that slows down our control path significantly.

devices = mpath_cli.list_paths(sid)
try:
mpath_cli.reconfigure()
except:
util.SMlog("WARNING: exception raised while attempting to"
" reconfigure")
time.sleep(5)

devices = mpath_cli.list_paths(sid)

try:
mpath_cli.remove_map(sid)
Expand Down