CP-28924: Declare thin provisioning capability for file based SRs #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change doesn't include a matching change to EXTSR, also it looks like THIN_PROVISIONING is actually being interpreted as OVER_COMMIT and that might be clearer. Whether ext should be able to over commit or not is a separate question given that it's not straightforward to extend the SR on local ext. |
|
Thanks Mark for spotting that, we have just discussed with Robert that it would make sense to do same thing for local ext just because THIN_PROVISIONING is a hint to XenCenter that there is no need to check for the available space in the SR since the VDI will just grow on demand. I will send an updated patch including ext SR. |
Signed-off-by: Thomas Mckelvey <thomas.mckelvey@citrix.com>
stefanopanella
force-pushed
the
feature/req488/master
branch
from
43b1953
to
b4e7b0c
Compare
|
Updated patch to include EXTSR.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mckelvey thomas.mckelvey@citrix.com