CP-33629 - Unit tests for HBA #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSymsCtx
previously approved these changes
May 18, 2020
tests/test_HBASR.py
Outdated
|
|
||
| sr = HBASR.HBASR() | ||
|
|
||
| self.assertEqual(sr.handles("blah"), False) |
There was a problem hiding this comment.
self.assertFalse/assertTrue
Signed-off-by: ben sims <ben.sims@citrix.com> debug
BenSimsCitrix
force-pushed
the
private/bensi/CP-33629
branch
from
73d22b9
to
f058c1c
Compare
TimSmithCtx
approved these changes
Jun 29, 2020
MarkSymsCtx
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for poorly covered HBA srs.