Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 1 futurize on SM #506

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

MarkSymsCtx
Copy link
Contributor

Mechanical code update using

futurize --stage1

https://python-future.org/futurize.html

Signed-off-by: Mark Syms mark.syms@citrix.com

@coveralls
Copy link

coveralls commented Jun 29, 2020

Coverage Status

Coverage increased (+0.04%) to 45.206% when pulling 6aa1021 on MarkSymsCtx:futurize_s1 into 80002ac on xapi-project:master.

Signed-off-by: Mark Syms <mark.syms@citrix.com>
Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,6 +1,7 @@
"""
Unit tests for mpathcount
"""
from __future__ import print_function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't do any harm but any idea why its import future here and not used it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh there a print on line 120, that must be why.

Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkSymsCtx MarkSymsCtx merged commit 4c9557f into xapi-project:master Oct 1, 2020
@MarkSymsCtx MarkSymsCtx deleted the futurize_s1 branch January 7, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants