-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage 1 futurize on SM #506
Conversation
e3a9e81
to
449d3f2
Compare
Signed-off-by: Mark Syms <mark.syms@citrix.com>
449d3f2
to
6aa1021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,6 +1,7 @@ | |||
""" | |||
Unit tests for mpathcount | |||
""" | |||
from __future__ import print_function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't do any harm but any idea why its import future here and not used it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh there a print on line 120, that must be why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mechanical code update using
futurize --stage1
https://python-future.org/futurize.html
Signed-off-by: Mark Syms mark.syms@citrix.com