Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-344254: simplify test-cleanup and use a magicmock for xapi #515

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

MarkSymsCtx
Copy link
Contributor

Preparation work for adding more tests

Signed-off-by: Mark Syms mark.syms@citrix.com

… of a fake

Signed-off-by: Mark Syms <mark.syms@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 44.886% when pulling 026caa6 on MarkSymsCtx:CA-344254 into 9d8ff5f on xapi-project:master.

Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkSymsCtx MarkSymsCtx merged commit 21dafdc into xapi-project:master Sep 22, 2020
@MarkSymsCtx MarkSymsCtx deleted the CA-344254 branch September 22, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants