Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-384783 Probe for NFS4 when rpcinfo does not include it #655

Merged

Conversation

TimSmithCtx
Copy link
Contributor

Just because the rpcinfo list obtained from rpcbind does not contain NFS4 does not mean it is not supported. Probe for it if it is not in the list. Some filers supporting both do not register NFS4 with rpcbind.

Just because the rpcinfo list obtained from rpcbind does not contain
NFS4 does not mean it is not supported. Probe for it if it is not in the
list. Some filers supporting both do not register NFS4 with rpcbind.

Signed-off-by: Tim Smith <tim.smith@citrix.com>
Copy link
Contributor

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with a server that supports NFSv3 only, will the NFS4 probe potentially take a long time to fail? (do we have a timeout?)

@TimSmithCtx
Copy link
Contributor Author

What happens with a server that supports NFSv3 only, will the NFS4 probe potentially take a long time to fail? (do we have a timeout?)

Since the probe is an attempted mount with a specific NFS version, in that case the NFS server should respond very quickly with "No. Go away."

@MarkSymsCtx
Copy link
Contributor

@benjamreis you should be aware of this, a bug from your recent changes. We have a customer who has a filer (TrueNAS) which supports NFSv4 but only returns 2 & 3 in the response from rpcinfo

@olivierlambert
Copy link

olivierlambert commented Nov 2, 2023

Why TrueNAS (which version? Core or Scale?) would returns 2&3 from rpcinfo while supporting also v4? Have you made a report to TrueNAS?

edit: do you mean that if your TrueNAS (question on the version still stands) supports 2,3 and 4, it will reports only 2 and 3? Is it an expected behavior? Because if not, it's not a bug here then.

@MarkSymsCtx
Copy link
Contributor

Why TrueNAS (which version? Core or Scale?) would returns 2&3 from rpcinfo while supporting also v4? Have you made a report to TrueNAS?

edit: do you mean that if your TrueNAS (question on the version still stands) supports 2,3 and 4, it will reports only 2 and 3? Is it an expected behavior? Because if not, it's not a bug here then.

It is not required to return 4 in response to rpcinfo, some filers do, some do not even when they support NFS v4.

@olivierlambert
Copy link

Okay that makes sense to also check it then. What's the functional issue with this, outside -I suppose- only mount it in v3 while v4 is also available? I'm not sure to understand the "bug" outside not using v4 while it's available but not announced?

@alexbrett
Copy link

The functional issue was the user was specifying to use v4 in the sr-create, and were getting an exception back saying it was an unsupported version, when prior to the recent changes this had worked fine, so it was a regression from their point of view.

@olivierlambert
Copy link

That makes sense, thanks!

@TimSmithCtx TimSmithCtx merged commit 136f348 into xapi-project:master Nov 6, 2023
2 checks passed
@TimSmithCtx TimSmithCtx deleted the private/timsmi/CA-384783 branch November 6, 2023 14:36
benjamreis added a commit to xcp-ng/sm that referenced this pull request Dec 18, 2023
See: xapi-project#655

Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
benjamreis added a commit to xcp-ng/sm that referenced this pull request Dec 19, 2023
See: xapi-project#655

Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
benjamreis added a commit to xcp-ng/sm that referenced this pull request Dec 19, 2023
See: xapi-project#655

Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Wescoeur pushed a commit to xcp-ng/sm that referenced this pull request Jan 23, 2024
…ct#655)

Just because the rpcinfo list obtained from rpcbind does not contain
NFS4 does not mean it is not supported. Probe for it if it is not in the
list. Some filers supporting both do not register NFS4 with rpcbind.

Signed-off-by: Tim Smith <tim.smith@citrix.com>
Wescoeur pushed a commit to xcp-ng/sm that referenced this pull request Feb 6, 2024
See: xapi-project#655

Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Wescoeur pushed a commit to xcp-ng/sm that referenced this pull request Jun 12, 2024
See: xapi-project#655

Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Wescoeur pushed a commit to xcp-ng/sm that referenced this pull request Jun 12, 2024
See: xapi-project#655

Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Wescoeur pushed a commit to xcp-ng/sm that referenced this pull request Oct 3, 2024
See: xapi-project#655

Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants