-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA-384783 Probe for NFS4 when rpcinfo does not include it #655
CA-384783 Probe for NFS4 when rpcinfo does not include it #655
Conversation
Just because the rpcinfo list obtained from rpcbind does not contain NFS4 does not mean it is not supported. Probe for it if it is not in the list. Some filers supporting both do not register NFS4 with rpcbind. Signed-off-by: Tim Smith <tim.smith@citrix.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens with a server that supports NFSv3 only, will the NFS4 probe potentially take a long time to fail? (do we have a timeout?)
Since the probe is an attempted mount with a specific NFS version, in that case the NFS server should respond very quickly with "No. Go away." |
@benjamreis you should be aware of this, a bug from your recent changes. We have a customer who has a filer (TrueNAS) which supports NFSv4 but only returns 2 & 3 in the response from |
Why TrueNAS (which version? Core or Scale?) would returns 2&3 from edit: do you mean that if your TrueNAS (question on the version still stands) supports 2,3 and 4, it will reports only 2 and 3? Is it an expected behavior? Because if not, it's not a bug here then. |
It is not required to return 4 in response to rpcinfo, some filers do, some do not even when they support NFS v4. |
Okay that makes sense to also check it then. What's the functional issue with this, outside -I suppose- only mount it in v3 while v4 is also available? I'm not sure to understand the "bug" outside not using v4 while it's available but not announced? |
The functional issue was the user was specifying to use v4 in the sr-create, and were getting an exception back saying it was an unsupported version, when prior to the recent changes this had worked fine, so it was a regression from their point of view. |
That makes sense, thanks! |
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
…ct#655) Just because the rpcinfo list obtained from rpcbind does not contain NFS4 does not mean it is not supported. Probe for it if it is not in the list. Some filers supporting both do not register NFS4 with rpcbind. Signed-off-by: Tim Smith <tim.smith@citrix.com>
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Just because the rpcinfo list obtained from rpcbind does not contain NFS4 does not mean it is not supported. Probe for it if it is not in the list. Some filers supporting both do not register NFS4 with rpcbind.