Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from jbuilder to dune #5

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Move from jbuilder to dune #5

merged 2 commits into from
Jan 2, 2019

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Dec 31, 2018

Signed-off-by: Konstantina Chremmou konstantina.chremmou@citrix.com

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis fails. I would consider replacing the Travis configuration with a one that uses xs-opam.

@kc284 kc284 closed this Jan 2, 2019
@kc284 kc284 reopened this Jan 2, 2019
@kc284
Copy link
Contributor Author

kc284 commented Jan 2, 2019

Travis is failing again; it's the same issue as in xcp-inventory; I don't fully understand what the issue is (on my local environment, for example, erratique.ch is resolved ok) - any tips?

@lindig
Copy link
Contributor

lindig commented Jan 2, 2019

I would move to a simpler setup (need to change the package names):

language: c
sudo: required
service: docker
install: wget https://raw.githubusercontent.com/ocaml/ocaml-ci-scripts/master/.travis-docker.sh
script: bash -ex .travis-docker.sh
env:
  global:
    - PACKAGE="xapi"
    - PINS="xapi:."
    - BASE_REMOTE="https://github.com/xapi-project/xs-opam.git"
  matrix:
    - DISTRO="debian-9-ocaml-4.07"

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
@lindig lindig merged commit f39d5c8 into xapi-project:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants