CA-341155: Fix console refresh when starting management server + other improvements #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention of the if-statement in `start` is to only refresh the consoles on the master if management is enabled, which is the case when the server is running on all IP addresses. The `listening_all` ref, however, is updated only _after_ the call to the `start` function. Instead refer to the `addr` parameter. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
The only user is `Xapi_pif.reconfigure_ipv6`, which does not actually need it anymore, because we always listen on all IPv4 and IPv6 addresses by default. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
|
Reviewers: I suggest reviewing patch-by-patch, and with whitespace changes suppressed for the "restructure" patch. |
This was referenced Aug 12, 2020
lindig
reviewed
Aug 12, 2020
lindig
reviewed
Aug 12, 2020
lippirk
reviewed
Aug 12, 2020
lippirk
reviewed
Aug 12, 2020
lippirk
reviewed
Aug 12, 2020
lippirk
reviewed
Aug 12, 2020
lippirk
reviewed
Aug 12, 2020
lippirk
approved these changes
Aug 14, 2020
lindig
approved these changes
Aug 14, 2020
Combined the server state refs into a single one with a clear type, and a matching state transformation function. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
The only way to update the HIMN address is through the `enable_himn` function. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.