Update opam metadata and update dune version to 3.0 #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBuica
approved these changes
May 29, 2024
robhoes
approved these changes
May 30, 2024
Adds mising dependencies and uses correct formula for enforcing same version Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Add the missing dependency on xapi-stdext-threads Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
With newer dune versions, unused bindings for binaries are also checked. The biggest chunks of code dropped are from tests: - the ones in stdext-encodings were missed when removing the tests, this was done because they were unused by xapi. - the export in rrd was never run, it's not trivial to get working due to changes that have happened in the meantime, and there were tests introduced in that same commit to ensure the data contains sane values. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This enables more warnings and fixes opam metadata generation Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
psafont
changed the title
|
I've run the re-enabled test for parallel vms more than 300 times, and it has yet to fail once. It seems pretty stable on my system. |
edwintorok
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mising dependencies and uses correct formula for enforcing same version
Added a missing dependency to message-switch-core. For some reason this was OK in ocaml 4.14.1 builds, but not on the 4.14.2 ones.
Update to dune version 3. This generates warnings for unused bindings on binaries, even if they don't have an empty mli defined. This needed some removals or changes to recover the unit tests