-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-49446: Update SR health to include new constructors #5659
CP-49446: Update SR health to include new constructors #5659
Conversation
Currently, the storage layer tracks two extra SR health statuses that XAPI is unaware of. These are "unreachable" and "unavailable". At present, the storage side simply maps these to "recovering" when sending information to the toolstack. This change will allow the storage layer to track more accurate SR health statuses. Signed-off-by: Colin James <colin.barr@cloud.com>
Updates the formatting to fit what is expected by CI. Signed-off-by: Colin James <colin.barr@cloud.com>
The failure happens because the external API changed.
|
Updates the last known hash to reflect recent changes to the data model. Signed-off-by: Colin James <colin.barr@cloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits should be squashed before merging
@@ -2791,6 +2791,8 @@ module Sr_stat = struct | |||
, [ | |||
("healthy", "Storage is fully available") | |||
; ("recovering", "Storage is busy recovering, e.g. rebuilding mirrors.") | |||
; ("unreachable", "Storage is unreachable") | |||
; ("unavailable", "Storage is unavailable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the ~lifecycle
arg of the health
field definition below, which this enum is used to indicate the change. E.g.:
~lifecycle:[(Prototyped, rel_kolkata, ""); (Published, rel_lima, ""); Extended, "24.16.0", "Enum extended with 'unreachable' and 'unavailable' values"]
Signed-off-by: Colin James <colin.barr@cloud.com>
Signed-off-by: Colin James <colin.barr@cloud.com>
Currently, the storage layer tracks two extra SR health statuses that XAPI is unaware of. These are "unreachable" and "unavailable". At present, the storage side simply maps these to "recovering" when sending information to the toolstack. This change will allow XAPI to track more accurate SR health statuses.
See this excerpt from
xapi-storage-plugins
(util.py
) which maps these new constructors to the extant "recovering" enum.