Link just qcheck-core, not qcheck #5685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcheck is in the wrong part of xs-opam currently, and although we're moving it this test really only needs qcheck-core, so link only that to fix an internal CI failure. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
|
Fixes a koji build failure resulted from merging #5682 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #5685 +/- ##
======================================
Coverage 51.3% 51.4%
======================================
Files 13 13
Lines 1927 1928 +1
======================================
+ Hits 990 991 +1
Misses 937 937
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Can you define the package for the test as well? (and double-check the opam metadata as well) |
|
wsproxy has already defined one on I fixed up the 2 opam files to have the correct dependencies now. |
robhoes
approved these changes
Jun 12, 2024
psafont
requested changes
Jun 12, 2024
GabrielBuica
approved these changes
Jun 12, 2024
psafont
approved these changes
Jun 12, 2024
psafont
reviewed
Jun 12, 2024
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/qcheck
branch
from
5b594cd
to
d5f1825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qcheck is in the wrong part of xs-opam currently, and although we're moving it this test really only needs qcheck-core, so link only that to fix an internal CI failure.