Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-49446: expose SR health values to Python #5747

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

MarkSymsCtx
Copy link
Contributor

The previous change under this ticket (5ec4c26) was incomplete and did not propagate the changes to the Python binding as used by the implementation of the Storage API provider.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #5747     +/-   ##
========================================
- Coverage    51.4%   44.8%   -6.6%     
========================================
  Files          13      16      +3     
  Lines        1928    2210    +282     
========================================
+ Hits          991     992      +1     
- Misses        937    1218    +281     

see 4 files with indirect coverage changes

Flag Coverage Δ
python2.7 45.5% <ø> (?)
python3.11 51.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ocaml/xapi-storage/generator/lib/control.ml Outdated Show resolved Hide resolved
Copy link
Contributor

@contificate contificate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I should have grep'd for more occurrences when I did the previous changes. Thanks.

@MarkSymsCtx MarkSymsCtx force-pushed the CP-49446 branch 2 times, most recently from 6d27e18 to e21b3e0 Compare June 27, 2024 12:58
Signed-off-by: Mark Syms <mark.syms@cloud.com>
@psafont psafont merged commit d768dd6 into xapi-project:master Jun 27, 2024
14 checks passed
@MarkSymsCtx MarkSymsCtx deleted the CP-49446 branch July 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants